Remove ContinueOnError from check-spelling step #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn spelling errors into warnings instead of failing the build.
weshaggard
requested review from
JonathanCrd,
KarishmaGhiya,
alzimmermsft,
joshfree,
msalaman,
tmeschter and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the spelling check configuration in the pipeline to allow builds to continue even when spelling errors are detected, treating them as warnings rather than build failures.
- Removes the
ContinueOnError: falseparameter from the check-spelling step - Changes spelling errors from build-breaking failures to warnings
Member
Author
|
If we want spelling to fail for some files, we can add a separate check for those files to make them fail |
feiskyer
pushed a commit
to feiskyer/microsoft-mcp
that referenced
this pull request
Sep 8, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn spelling errors into warnings instead of failing the build.